Cleanup mesh intersection#281
Conversation
|
@Sichao25 you may want to wait until @abhiyan123 indicates if he will merge these changes back to #209 or not to do the review. Once he indicates his preference I'd like to move quickly to get this finalized. There is still a lot of cleanup that could and maybe should be done to better decouple components. My strategy was to try to at least:
The error handling bits of this are still a mess, but the PR is already big enough as is. We will have to take a pass at resolving the error handling mismatch when we fix the exceptions in the rest of the library. For the petsc errors, we can utilze the macro/exception type I previously implemented for MuMFiM. It looks like using PkgConfig for the petsc configuration broke the CI build...In my personal builds I've had better luck with the |
4956aa1 to
708b844
Compare
|
The issue with the |
649fc41 to
195bbe9
Compare
195bbe9 to
b42e2f0
Compare
b42e2f0 to
5f1a1bb
Compare
5f1a1bb to
c46358b
Compare
c46358b to
3fb2430
Compare
82dddee to
bf6321c
Compare
a3cc6ef to
b21ec6c
Compare
3f8a95d to
d545de0
Compare
d545de0 to
b3a0b25
Compare
|
@abhiyan123 all but the one test is running on GPU. We just need to debug that and we should be able to merge. |
This PR is an extension of #209. I refactored Abhiyan's code to get it closer to a state that we can merge.
@abhiyan123 if you would rather merge this and work off of your PR. I'm fine with that, I just want to get the first pass at mesh_intersections in quickly.